#18624: Implement the lift theorem for linear matroids
-------------------------------------+-------------------------------------
Reporter: Rudi | Owner: Rudi
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: matroid theory | Resolution:
Keywords: | Merged in:
Authors: Rudi Pendavingh | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/Rudi/implement_the_lift_theorem_for_linear_matroids|
995e9b6341611cad6f3c96416b67ba4afaf1f5d6
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
One major thing: `lift_map` needs doctests.
A couple of minor things (all but the first two you can ignore):
- Please remove all trailing whitespace.
- Citations should be make by `[refname]_`.
- I know it's not part of this ticket, but instead of
`http://arxiv.org/abs/1203.0910`, you can (should) use
{{{arxiv:`1203.0910`}}}. You can also make {{{`(-i, i)`}}} for math
formatting.
- You should try to make all lines under 80 characters; in particular, the
moved citation.
- In the `INPUT:` of `lift_map` should be `--` instead of the comma `,`.
- I'd remove the period `.` in the `OUTPUT:` section of `lift_map` since
it is not a sentence.
- Don't be afraid of using (inline) math formatting/latex (mainly I'm
thinking of `lift_cross_matrix`).
Stefan, are you going to be doing the rest of the review?
--
Ticket URL: <http://trac.sagemath.org/ticket/18624#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
