#18624: Implement the lift theorem for linear matroids
-------------------------------------+-------------------------------------
       Reporter:  Rudi               |        Owner:  Rudi
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.8
      Component:  matroid theory     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Rudi Pendavingh    |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/Rudi/implement_the_lift_theorem_for_linear_matroids|  
00bc8254e278beaa022697605ec39b6a570686a0
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by Rudi):

 Replying to [comment:17 tscrim]:
 > One major thing: `lift_map` needs doctests.
 >
 > A couple of minor things (all but the first two you can ignore):
 >
 > - Please remove all trailing whitespace.
 > - Citations should be make by `[refname]_`.
 > - I know it's not part of this ticket, but instead of
 `http://arxiv.org/abs/1203.0910`, you can (should) use
 {{{arxiv:`1203.0910`}}}. You can also make {{{`(-i, i)`}}} for math
 formatting.
 > - You should try to make all lines under 80 characters; in particular,
 the moved citation.
 > - In the `INPUT:` of `lift_map` should be `--` instead of the comma `,`.
 > - I'd remove the period `.` in the `OUTPUT:` section of `lift_map` since
 it is not a sentence.
 > - Don't be afraid of using (inline) math formatting/latex (mainly I'm
 thinking of `lift_cross_matrix`).
 >

 Thanks. I think my last commit covers each of these issues except for the
 last one.

--
Ticket URL: <http://trac.sagemath.org/ticket/18624#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to