#18624: Implement the lift theorem for linear matroids
-------------------------------------+-------------------------------------
Reporter: Rudi | Owner: Rudi
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: matroid theory | Resolution:
Keywords: | Merged in:
Authors: Rudi Pendavingh | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/Rudi/implement_the_lift_theorem_for_linear_matroids|
00bc8254e278beaa022697605ec39b6a570686a0
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
Replying to [comment:22 Rudi]:
> Replying to [comment:21 yomcat]:
> > The code looks good (no running capability at the moment though). If
Stefan doesn't beat me to it, I'll give it a proper go tomorrow.
> >
> Thanks!
Two things I missed on my quick lookthrough; both are in `lift_map`. Your
missing a blankline after `EXAMPLES::` and bullet point lists need to be
aligned as:
{{{
- this is a long item
which is aligned like this
- here is the second item
}}}
One thing I messed up on is {{{:arxiv:`1203.0910`}}} (I missed the leading
colon). Also don't include the triple { } braces (they are just here so
that it displays properly).
> > One thing: Why are the imports interspersed throughout the code,
instead of collected altogether at the top. I don't know what the
convention is though.
> Neither do I. Actually, I also don't know whether it makes any
difference for the compiled code either.
It takes more time to have an import inside of a method because python has
to resolve that import (or seeing it already has been imported) each time
the method is called. However one sometimes needs to do this to take care
of circular imports: file A imports something from file B, but file B also
needs to import something from file A (or potentially larger cycles).
--
Ticket URL: <http://trac.sagemath.org/ticket/18624#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
