#18720: Change diagram algebra basis set partitions from list to generator
-------------------------------------+-------------------------------------
Reporter: ghseeli | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: sage-6.8
Component: algebra | Resolution:
Keywords: days65, partition | Merged in:
algebra, diagram algebra | Reviewers: Travis Scrimshaw
Authors: ghseeli | Work issues:
Report Upstream: N/A | Commit:
Branch: | 347da7e20bd9e0a4a3a8cf83b571cbbda7ef0c1c
u/tscrim/diagram_algebra_improvements-18720| Stopgaps:
Dependencies: #18707 |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* commit: 879e2b6d89475802810e573bf8d396e401ab4d06 =>
347da7e20bd9e0a4a3a8cf83b571cbbda7ef0c1c
* dependencies: => #18707
* branch:
u/ghseeli/change_diagram_algebra_basis_set_partitions_from_list_to_generator
=> u/tscrim/diagram_algebra_improvements-18720
* reviewer: => Travis Scrimshaw
Comment:
Yes, that does. You'll have to rebase over my recent changes. I made it so
that we don't create the intermediary `SetPartition` objects, which gives
a pretty good speedup (the time to run the tests went from over 7 seconds
to just over 6 seconds). I also merged in #18707 to avoid any potential
merge conflicts.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=e41dd3cd260e68f09dcecf707c2dc603c46c85f7
e41dd3c]||{{{added code to draw linear combinations of diagram algebra
elements instead of just basis elements.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=dc509a6098b6c26498a120551637d196f5bb81fc
dc509a6]||{{{removed redundancy in code by moving the diagram algebra
elements _latex_ method to the _latex_term method in the diagram algebra
class}}}||
||[http://git.sagemath.org/sage.git/commit/?id=a7a54e7b25d5b2965f63c5dbf99b3507d757e599
a7a54e7]||{{{add indirect doctest comment to doctest for latex command in
DiagramAlgebras and also removed unnecessary parenthesis from conditional
statements in this method.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4095ded7a8449ef9b636a7056cba71b8c079e531
4095ded]||{{{Merge branch
'u/ghseeli/implement_latex_code_for_all_diagram_algebra_elements' of
trac.sagemath.org:sage into
u/tscrim/diagram_algebra_improvements-18720}}}||
||[http://git.sagemath.org/sage.git/commit/?id=347da7e20bd9e0a4a3a8cf83b571cbbda7ef0c1c
347da7e]||{{{Removing the creation of intermediate SetPartition
objects.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18720#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
