#18744: Improve Cartan Type Recognition
-------------------------------------+-------------------------------------
       Reporter:  jonathan.judge     |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-6.8
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jonathan.judge/improve_cartan_type_recognition|  
d8d1685ebc7dd76645a0172b7ecb65e5037119e7
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jonathan.judge):

 * commit:   => d8d1685ebc7dd76645a0172b7ecb65e5037119e7


Comment:

 I just committed some initial work.

 There are a couple things I'm not happy about at the moment:

 - the change on line 18772 of generic_graph.py from
 {{{G.relabel(return_map=True)}}} to
 {{{GenericGraph.relabel(G,return_map=True)}}} was made due to the
 conflicting definition of the relabel function in !DynkinDiagram. I tried
 to get around it by converting !DynkinDiagrams to !DiGraphs, but somehow I
 couldn't make it work. If there's a better way, please let me know.

 - there's some index set weirdness that I got around in finite type as on
 line 275 of cartan_matrix.py, but it feels hacky and I would like a better
 solution.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=d8d1685ebc7dd76645a0172b7ecb65e5037119e7
 d8d1685]||{{{Initial commit of changes}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18744#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to