#17392: Make list of built-in normal form games
-------------------------------------+-------------------------------------
       Reporter:  kcrisman           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.5
      Component:  game theory        |   Resolution:
       Keywords:  days64             |    Merged in:
        Authors:  Vincent Knight,    |    Reviewers:  Karl-Dieter Crisman
  James Campbell                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  e57758e52d52b993fc4205acbea6d8a2cce1a34b
  u/vinceknight/catalog_of_games     |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by tscrim):

 Looks good from a git standpoint. I'd also change {{{:math:`x + y`}}} to
 simply {{{`x + y`}}} and `.. math::` to `.. MATH::`.

 You'll also note that because these are imported in the catalog:
 {{{
 from sage.game_theory.normal_form_game import NormalFormGame
 from sage.matrix.constructor import matrix
 from sage.functions.generalized import sign
 }}}
 I believe they appear under tab completion. To fix this, I'd add a
 {{{
 del matrix
 del sign
 }}}
 at the end of the file.

 I believe you're also importing at startup a good part of the game theory
 with the catalog. I'd change the import in `all.py` to
 {{{
 lazy_import('sage.game_theory', 'catalog', 'game_theory')
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/17392#comment:43>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to