#18756: Use coerce actions in the category framework
-------------------------------------+-------------------------------------
       Reporter:  SimonKing          |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.8
      Component:  coercion           |   Resolution:
       Keywords:  cython, coercion,  |    Merged in:
  actions, categories                |    Reviewers:  Travis Scrimshaw
        Authors:  Simon King         |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  dfba8b8dfcaf23f76d4f62f575b862aba48b0be8
  u/SimonKing/combinatorial_free_module_cython_coercion|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * reviewer:   => Travis Scrimshaw


Comment:

 +1 to including category support for actions. So I'm happy with this patch
 modulo this change:
 {{{#!diff
 -        NOTE:
 -
 -        If a parent implements :meth:`_get_action_` then it has
 precedence
 -        over an implementation obtained from the category framework.
 -        However, if :meth:`_get_action_` returns None, then
 -        ``self.category().parent_class._get_action_`` has a chance to
 give
 -        a better answer.
 +        .. NOTE::
 +
 +            If a parent implements :meth:`_get_action_` then it has
 precedence
 +            over an implementation obtained from the category framework.
 +            However, if :meth:`_get_action_` returns ``None``, then
 +            ``self.category().parent_class._get_action_`` has a chance to
 give
 +            a better answer.
 }}}

 Also +1 to cythonizing (key components of)
 `CombinatorialFreeModule(Element)`.

--
Ticket URL: <http://trac.sagemath.org/ticket/18756#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to