#18809: Undo suspicious isinstance() changes from #15984
---------------------------+----------------------------------
   Reporter:  jdemeyer     |            Owner:
       Type:  enhancement  |           Status:  new
   Priority:  major        |        Milestone:  sage-6.8
  Component:  misc         |         Keywords:
  Merged in:               |          Authors:  Jeroen Demeyer
  Reviewers:               |  Report Upstream:  N/A
Work issues:               |           Branch:
     Commit:               |     Dependencies:
   Stopgaps:               |
---------------------------+----------------------------------
 #15984 replaced many conditions of the form
 {{{
 type(a) == type(b)
 }}}
 to
 {{{
 isinstance(a, type(b))
 }}}

 I think that the intention of {{{type(a) == type(b)}}} really is to
 compare whether two objects have equal type. So we undo these changes
 (while changing `==` to `is` for these type checks).

--
Ticket URL: <http://trac.sagemath.org/ticket/18809>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to