#18809: Undo suspicious isinstance() changes from #15984
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.8
Component: misc | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: Wilfried Luebbe
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/18809 | e82c8f99d6493f48d3a02c598fc723e693f5616f
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by wluebbe):
* status: needs_review => positive_review
* reviewer: => Wilfried Luebbe
Comment:
The changes back to {{{type()}}} are in the context of equality tests. As
equality is a symmetric relation tests for type identity are clearly more
appropriate than tests for a subclass relationship.
Other changes introduce explicit type names for expressions like
{{{type(1)}}} which a good thing.
This looks good to me. By the way: I built on Ubuntu 15.04 and all tests
pass.
PS: Thank you for your critical review of #18796.
--
Ticket URL: <http://trac.sagemath.org/ticket/18809#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
