#15375: Extended Affine Weyl Groups SD40
-------------------------------------+-------------------------------------
       Reporter:  bump               |        Owner:  bump
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.8
      Component:  combinatorics      |   Resolution:
       Keywords:  days54, coxeter,   |    Merged in:
  days64, days65                     |    Reviewers:  Dan Bump, Anne
        Authors:  Daniel Bump, Dan   |  Schilling
  Orr, Anne Schilling, Mark          |  Work issues:
  Shimozono, Nicolas Thiery.         |       Commit:
Report Upstream:  N/A                |  ee155e445baa2c406162df421ad8ad9b10d4292d
         Branch:  public/15375       |     Stopgaps:
   Dependencies:  #10963, #14102     |
-------------------------------------+-------------------------------------

Comment (by aschilling):

 Replying to [comment:117 bump]:
 > On my machine it builds and all tests pass. But two buildbots are
 failing to build with cython errors.
 >
 > Surely this can have nothing to do with this patch.
 >
 > I'm changing the status to needs_review. I hesitate to change it to
 positive_review until the patchbot is happy.

 For me everything builds fine. I ran `sage -testall` and got the following
 failures
 {{{
 sage -t src/sage/groups/perm_gps/permgroup_named.py
 **********************************************************************
 File "src/sage/groups/perm_gps/permgroup_named.py", line 2609, in
 
sage.groups.perm_gps.permgroup_named.PSL.ramification_module_decomposition_hurwitz_curve
 Failed example:
     G.ramification_module_decomposition_hurwitz_curve() # random, optional
 - database_gap
 Exception raised:
     Traceback (most recent call last):
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 496, in _run
         self.compile_and_execute(example, compiler, test.globs)
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 858, in compile_and_execute
         exec(compiled, globs)
       File "<doctest
 
sage.groups.perm_gps.permgroup_named.PSL.ramification_module_decomposition_hurwitz_curve[1]>",
 line 1, in <module>
         G.ramification_module_decomposition_hurwitz_curve() # random,
 optional - database_gap
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/groups/perm_gps/permgroup_named.py", line 2630, in
 ramification_module_decomposition_hurwitz_curve
         mults = gap.eval("ram_module_hurwitz("+str(q)+")")
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/interfaces/gap.py", line 568, in eval
         result = Expect.eval(self, input_line, **kwds)
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/interfaces/expect.py", line 1239, in eval
         for L in code.split('\n') if L != ''])
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/interfaces/gap.py", line 766, in _eval_line
         raise RuntimeError(message)
     RuntimeError: Gap produced error output
     Error, sorry, the GAP Tables Of Marks Library is not installed

        executing ram_module_hurwitz(13);
 **********************************************************************
 File "src/sage/groups/perm_gps/permgroup_named.py", line 2657, in
 
sage.groups.perm_gps.permgroup_named.PSL.ramification_module_decomposition_modular_curve
 Failed example:
     G.ramification_module_decomposition_modular_curve() # random, optional
 - database_gap
 Exception raised:
     Traceback (most recent call last):
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 496, in _run
         self.compile_and_execute(example, compiler, test.globs)
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 858, in compile_and_execute
         exec(compiled, globs)
       File "<doctest
 
sage.groups.perm_gps.permgroup_named.PSL.ramification_module_decomposition_modular_curve[1]>",
 line 1, in <module>
         G.ramification_module_decomposition_modular_curve() # random,
 optional - database_gap
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/groups/perm_gps/permgroup_named.py", line 2674, in
 ramification_module_decomposition_modular_curve
         mults = gap.eval("ram_module_X("+str(q)+")")
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/interfaces/gap.py", line 568, in eval
         result = Expect.eval(self, input_line, **kwds)
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/interfaces/expect.py", line 1239, in eval
         for L in code.split('\n') if L != ''])
       File "/Applications/sage/local/lib/python2.7/site-
 packages/sage/interfaces/gap.py", line 766, in _eval_line
         raise RuntimeError(message)
     RuntimeError: Gap produced error output
     Error, sorry, the GAP Tables Of Marks Library is not installed

        executing ram_module_X(7);
 **********************************************************************
 2 items had failures:
    1 of   3 in
 
sage.groups.perm_gps.permgroup_named.PSL.ramification_module_decomposition_hurwitz_curve
    1 of   3 in
 
sage.groups.perm_gps.permgroup_named.PSL.ramification_module_decomposition_modular_curve
     [439 tests, 2 failures, 3.16 s]
 ----------------------------------------------------------------------
 sage -t src/sage/groups/perm_gps/permgroup_named.py  # 2 doctests failed
 ----------------------------------------------------------------------
 Total time for all tests: 3.3 seconds
     cpu time: 2.3 seconds
     cumulative wall time: 3.2 seconds
 }}}
 {{{
 sage -t src/sage/tests/gap_packages.py
 **********************************************************************
 File "src/sage/tests/gap_packages.py", line 15, in sage.tests.gap_packages
 Failed example:
     test_packages(['atlasrep', 'tomlib'])    # optional - database_gap
 Expected:
       Status   Package    GAP Output
     +--------+----------+------------+
                atlasrep   true
                tomlib     true
 Got:
       Status    Package    GAP Output
     +---------+----------+------------+
       Failure   atlasrep   fail
       Failure   tomlib     fail
 **********************************************************************
 1 item had failures:
    1 of   4 in sage.tests.gap_packages
     [9 tests, 1 failure, 0.18 s]
 ----------------------------------------------------------------------
 sage -t src/sage/tests/gap_packages.py  # 1 doctest failed
 ----------------------------------------------------------------------
 Total time for all tests: 0.2 seconds
     cpu time: 0.2 seconds
     cumulative wall time: 0.2 seconds
 }}}

 I do not think they are related to this branch. So unless there is
 something else, I guess we can set positive review.

--
Ticket URL: <http://trac.sagemath.org/ticket/15375#comment:118>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to