#6685: [with patch, positive review] include pictures in the reference manual 
and
notebook introspection
---------------------------+------------------------------------------------
 Reporter:  jhpalmieri     |       Owner:  tba                        
     Type:  enhancement    |      Status:  new                        
 Priority:  major          |   Milestone:  sage-4.1.2                 
Component:  documentation  |    Keywords:                             
 Reviewer:  Dan Drake      |      Author:  John Palmieri, Mitesh Patel
   Merged:                 |  
---------------------------+------------------------------------------------
Changes (by newvalueoldvalue):

  * reviewer:  => Dan Drake
  * author:  => John Palmieri, Mitesh Patel


Comment:

 There's two things going on here: one, the code that allows us to use the
 "{{{.. image::}}}" directives and have them work; two, the parts of the
 patch that actually change some docstrings to include some images. I'm
 giving this a positive review, and have split the "v2" patch into two
 patches:

   * attachment:trac_6685-proposal.patch includes just the parts from
 attachment:trac_6685-ref_pictures_no_symlinks_v2.patch that actually add
 the new support for image directives.
   * attachment:trac_6685-usage-examples.patch includes the binary image
 from the "v2" patch, as well as the change to the reference manual to
 include that image. I also added a second image and a change to a
 docstring that demonstrates that you can now include images and see them
 when viewing docstrings in the notebook -- try {{{plot?}}} with this patch
 applied.

 My positive review certainly applies to the "proposal" patch and I think
 the release manager should merge it.

 I propose that we ''not'' merge the usage examples patch and just leave it
 here so people can see how the image inclusion stuff works. We can hash
 out elsewhere the details of how to autogenerate images, do image
 doctests, and so on. Thoughts?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6685#comment:11>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to