#18760: Posets: Slightly faster is_lattice()
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  minor              |    Milestone:  sage-6.8
      Component:  combinatorics      |   Resolution:
       Keywords:  posets             |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/posets__slightly_faster_is_lattice__|  
46cf5a4fa8775ba1fdcb9d6042d16a14092032e1
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by deinst):

 * status:  needs_review => needs_work


Comment:

 Please, please, please, please run `make ptestlong` or `make testlong`
 before submitting something for review, no matter how trivial the change.
 The heat death of the universe is progressing just fine by itself. In
 other words you are missing a pair of parentheses after cardinality.

 The fact that it runs slightly faster than twice as fast on average for
 all posets of size 8 is surprising at first but not unexpected  we are
 much faster on those posets with a bottom but no top, about the same (but
 very fast) for the ones with no bottom and about as fast to twice as fast
 for the ones with both.

--
Ticket URL: <http://trac.sagemath.org/ticket/18760#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to