#18760: Posets: Slightly faster is_lattice()
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.8
Component: combinatorics | Resolution:
Keywords: posets | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/posets__slightly_faster_is_lattice__|
cfbc7daccfee560158f7d52a9aa0e00dfeb7d868
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jmantysalo):
Replying to [comment:9 deinst]:
> are missing a pair of parentheses after cardinality.
Some days I think I should flush myself down the toilet.
I did the change with `()` and ran (short) tests. Then I happen to crash
something and had to re-did the oneliner. And I forget the parenthesis.
> Please, please, please, please run `make ptestlong` or `make testlong`
before submitting something for review, no matter how trivial the change.
Does it differ from `sage -t -a --long`? Anyways, I am now running `make
ptestlong` and will mark this as needs_review after that.
There were some strange errors in compiling, maybe because of new version
of Sage as a base. This is now pushed with `git -f`.
> The fact that it runs slightly faster than twice as fast on average for
all posets of size 8 is surprising at first but not unexpected we are
much faster on those posets with a bottom but no top, about the same (but
very fast) for the ones with no bottom and about as fast to twice as fast
for the ones with both.
True. Of course this means nothing until we get #14110 and #17147 done.
--
Ticket URL: <http://trac.sagemath.org/ticket/18760#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
