#17030: Knot Theory as a part of GSoC 2014.
-------------------------------------+-------------------------------------
Reporter: amitjamadagni | Owner: amitjamadagni
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.9
Component: algebraic | Resolution:
topology | Merged in:
Keywords: | Reviewers: Miguel Marco, Karl-
Authors: Amit Jamadagni, | Dieter Crisman, Frédéric Chapoton
Miguel Marco | Work issues:
Report Upstream: N/A | Commit:
Branch: | 06aad784cdd03604d77f9f9c7e6c9332a4982fc6
public/ticket/17030 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
Okay, I've done my initial pass. There's still a lot more work to be done
with respect to the documentation, in particular, the class level doc for
the respective `Link` and `Knot` classes. (This needs to be cleaned up
before a positive review; the other doc is not so important to me but it
would be nice to have.)
I couldn't get one of the doctests to pass with cb84cec:
{{{
sage -t link.py
**********************************************************************
File "link.py", line 1185, in sage.knots.link.Link.orientation
Failed example:
L.orientation()
Expected:
[-1, -1, 1]
Got:
[-1, -1, -1]
}}}
I believe this was a typo of a missing minus sign (if I understand the
knot correctly from the plot).
I made a lot of minor to micro optimizations and code cleanup. I created a
`Knot` class as Miguel suggested (and was what I had in mind initially). I
created an equality check by looking at the braids (is that a link
invariant?) and put a warning message about false negatives (but if it is
a link invariant, then we should be able to remove the warning message).
There shouldn't be any more large refactoring of the code after this point
I think.
I think for the catalog, we should open up a followup ticket rather than
put an explicit todo in the file. However a big +1 on doing this.
--
Ticket URL: <http://trac.sagemath.org/ticket/17030#comment:122>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
