#18987: Parallel computation for TilingSolver.number_of_solutions
-------------------------+-------------------------------------------------
Reporter: | Owner:
slabbe | Status: needs_review
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Vincent Delecroix
combinatorics | Work issues:
Keywords: | Commit:
Authors: | 2133ecdcffb1b993049874c8be6cad2b1224a73a
Sébastien Labbé | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18987 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by vdelecroix):
Are you sure `ncube_isometry_group` is worth a `@cached_function`?
In `ncube_isometry_group_modpi` why are you building `MatrixGroup`?
In
{{{
P_coset = set(frozenset((m.matrix() * self).canonical() for m in coset)
for coset in L)
return set(next(iter(s)) for s in P_coset)
}}}
You are building a lot of images to consider `matrix x polyomino` to use
just one at the end. Why not
{{{
return set((L[0].matrix() * self).canonical() for coset in L)
}}}
And if you were not using matrix groups you can even do
{{{
return set((L[0] * self).canonical() for coset in L)
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/18987#comment:42>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
