#19016: A more naive sage.structure.element.__hash__
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.9
defect | Resolution:
Priority: | Merged in:
blocker | Reviewers:
Component: misc | Work issues:
Keywords: | Commit:
Authors: | 754dc5794a1a7004c8844cf7cfb64220957c36a5
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/19016 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by vdelecroix):
Replying to [comment:4 ncohen]:
> If you see a way to turn #18246 into a `needs_review` ticket soon, then
I do not mind. But I don't want to fight against 800 screaming guys again,
and I want this to be solved.
Putting in `needs_review` just need some efforts. I can dig into it if you
are up for a review.
> What about a middle ground: raise a warning, which would appear only
once, whenever this 0 hash function is used?
It is already a bit better.
> This is a very bad bug and it needs to be fixed.
It is.
> Creating tickets that we forget is nto much more responsible than doing
nothing.
I did not forget as you see ;-)
With your implementation, I am pretty sure that the running time of the
tests will be much slower. Sage very often put elements in dictionaries or
sets. Your solution does not help users to see that `__hash__` is
important, because you will not run into bugs, just into very slow code. I
agree that you fix the error but you open a much more annoying feature.
--
Ticket URL: <http://trac.sagemath.org/ticket/19016#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
