#18987: Parallel computation for TilingSolver.number_of_solutions
-------------------------+-------------------------------------------------
Reporter: | Owner:
slabbe | Status: needs_review
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Vincent Delecroix
combinatorics | Work issues:
Keywords: | Commit:
Authors: | 0d68ecec28cb92d9e78a92d6e733d42b3e8941c1
Sébastien Labbé | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18987 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by vdelecroix):
Replying to [comment:53 slabbe]:
> Replying to [comment:46 vdelecroix]:
> > Perhaps the way it is implemented is wrong. For example
> > {{{
> > sage: %timeit P = [s.matrix() for s in SymmetricGroup(4)]
> > 1 loops, best of 3: 1.27 ms per loop
> > }}}
>
> I removed the `cached_method`. Do you want me to replace the code based
on `WeylGroup(['B',n])` by the `SymmetricGroup` + `diagonal_matrix of
signs` code you propose? I think that this improvement should be done in
`WeylGroup` in another ticket.
Nope. I also the think that the `WeylGroup` code has to be improved.
> Also, for timing improvements in that file `tiling.py`, there is a
another more important thing to spend time on because a lot of time is
spent creating vectors from tuple (because coordinates are stored as
tuple). This should be done in another ticket.
Did you notice that
{{{
sage: t = map(vector, t)
}}}
is much slower than
{{{
sage: V = FreeModule(ZZ,12)
sage: t = map(V,t)
}}}
(I measure a factor x8 in `__sub__` and `__add__` for example)
Moreover, everything would be faster if you would store integer vectors
instead of tuples (and an attribute `self._free_module`). Why aren't you
doing that?
--
Ticket URL: <http://trac.sagemath.org/ticket/18987#comment:54>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
