#18454: New `random_cone()` function
-------------------------------------+-------------------------------------
       Reporter:  mjo                |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.8
      Component:  geometry           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Michael Orlitzky   |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/novoselt/ticket/18454            |  a07efa959bcbd088f34e3e4b7bd0a653cfaa998d
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by mjo):

 Replying to [comment:25 novoselt]:
 > OK:
 >  - merged current version of #18613 to make isomorphism checks work as
 expected
 >  - there was a duplicate piece of code, removed
 >  - I tweaked some code, hopefully not unreasonably
 >
 > Regarding redundant tests I was mostly complaining about things like...
 But if you really like to keep them it is fine with me.

 Nope, I just had some other redundant tests in mind. You're right, I've
 removed them. Thanks for the rest of the changes, too, they all look good.
 Just need a thumbs up on my last commit and I think this is ready.

--
Ticket URL: <http://trac.sagemath.org/ticket/18454#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to