#18740: Reduce overhead for relative number field elements
-------------------------------------+-------------------------------------
       Reporter:  pbruin             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  minor              |    Milestone:  sage-6.9
      Component:  number fields      |   Resolution:
       Keywords:  relative number    |    Merged in:
  field pari                         |    Reviewers:
        Authors:  Peter Bruin        |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  c661096b45e80a7227eba537ae1f7dc9e3836c1d
  u/pbruin/18740-relative_number_fields|     Stopgaps:
   Dependencies:  #18727, #18739     |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):

 * status:  needs_review => needs_work
 * milestone:  sage-6.8 => sage-6.9


Comment:

 Hello Peter,

 Instead of
 {{{
 f = pari(self._coefficients()).Polrev()
 return f.change_variable_name(name)
 }}}
 you can do
 {{{
 return pari(self._coefficients()).Polrev(name)
 }}}
 that would avoid a copy.

 Why did you rename `_rnf_equations` into `_rnfeq`. I understand that
 `relative_number_field_equations` is a bit long but the Sage standard is
 more toward no abbreviation at all. Is the name `rnfeq` standard in
 PARI/GP?

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/18740#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to