#18740: Reduce overhead for relative number field elements
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.9
Component: number fields | Resolution:
Keywords: relative number | Merged in:
field pari | Reviewers:
Authors: Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: | c661096b45e80a7227eba537ae1f7dc9e3836c1d
u/pbruin/18740-relative_number_fields| Stopgaps:
Dependencies: #18727, #18739 |
-------------------------------------+-------------------------------------
Comment (by pbruin):
Salut Vincent,
> Instead of
> {{{
> f = pari(self._coefficients()).Polrev()
> return f.change_variable_name(name)
> }}}
> you can do
> {{{
> return pari(self._coefficients()).Polrev(name)
> }}}
> that would avoid a copy.
OK, I will change this.
> Why did you rename `_rnf_equations` into `_rnfeq`. I understand that
`relative_number_field_equations` is a bit long but the Sage standard is
more toward no abbreviation at all. Is the name `rnfeq` standard in
PARI/GP?
The reason is that `_pari_rnfequation()` was a wrapper around the PARI/GP
function `rnfequation()`, whereas `_pari_rnfeq()` wraps the internal PARI
library function `nf_rnfeq()`. It is not just a change of name, but a
different method returning similar (but more) output. I think it is best
to keep the name of the Sage close to the PARI name. I didn't want to
keep a separate method `_pari_rnfequation()` because it was a private
method which isn't used anymore.
--
Ticket URL: <http://trac.sagemath.org/ticket/18740#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
