#18740: Reduce overhead for relative number field elements
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-6.9
Component: number fields | Resolution:
Keywords: relative number | Merged in:
field pari | Reviewers: Vincent Delecroix
Authors: Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: | e59e8ec7b0ac671167d7df8acd00631cb1fcdc76
u/pbruin/18740-relative_number_fields| Stopgaps:
Dependencies: #18727, #18739 |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => positive_review
* reviewer: => Vincent Delecroix
Comment:
Replying to [comment:7 pbruin]:
> > Why did you rename `_rnf_equations` into `_rnfeq`. I understand that
`relative_number_field_equations` is a bit long but the Sage standard is
more toward no abbreviation at all. Is the name `rnfeq` standard in
PARI/GP?
> The reason is that `_pari_rnfequation()` was a wrapper around the
PARI/GP function `rnfequation()`, whereas `_pari_rnfeq()` wraps the
internal PARI library function `nf_rnfeq()`. It is not just a change of
name, but a different method returning similar (but more) output. I think
it is best to keep the name of the Sage close to the PARI name. I didn't
want to keep a separate method `_pari_rnfequation()` because it was a
private method which isn't used anymore.
I agree that your way is better.
--
Ticket URL: <http://trac.sagemath.org/ticket/18740#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
