#18997: Unitary and symplectic (dual) polar graphs
-------------------------+-------------------------------------------------
Reporter: | Owner:
dimpase | Status: needs_work
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | 35a9b1752da8eadddc03b68e584ceffa9e14bc93
Report Upstream: N/A | Stopgaps:
Branch: |
u/dimpase/unitary |
Dependencies: |
#18972 |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Helloooooooo Dima,
Here is a 'first-pass' review:
- This doctest is way too long:
{{{
sage: %time
graphs.SymplecticGraph(6,4,algorithm="gap").is_strongly_regular(parameters=True)
CPU times: user 22 s, sys: 132 ms, total: 22.2 s
Wall time: 21.1 s
(1365, 340, 83, 85)
}}}
You will see several places in this file doctests disabled because they
take
~5seconds. This, because the doctests are run very often by a lot of
people,
and we can't have them compute for 20 seconds whenever we add a function
(and
we do add many). Could you replace this `6,4` by `4,4` or something?
- Why is this only checked when `algorithm="gap"`?
{{{
if d < 1 or d%2 != 0:
raise ValueError("d must be even and greater than 2")
}}}
- `_polar_graph` -- misses an 'INPUT' section
- Could you merge this branch with the latest version of its dependency?
- in `_polar_Graph` -- why upper case `G`?
- same function: would it make sense to compute the list of edges of the
graph
in GAP instead of doing it in Sage, which triggers GAP calls? Just
wondering,
as it seems that interacting with GAP is often costly.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18997#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
