#18997: Unitary and symplectic (dual) polar graphs
-------------------------+-------------------------------------------------
Reporter: | Owner:
dimpase | Status: needs_work
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Nathann Cohen
theory | Work issues:
Keywords: | Commit:
Authors: Dima | acc985a045f02a1c796accd9a029ae809a0a92fd
Pasechnik | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dimpase/unitary |
Dependencies: |
#18972 |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Helloooooooo Dima,
- About the methods with a "algorithm" keyword: some of them do not have
an
`INPUT` block where the parameter is described. Also, it would be better
if
instead of checking `!= 'gap'` you tested `algorithm =='Gap'` then
`algorithm
is None` and finally raised an exception if the argument does not
beelong to
the allowed list. This being said, I would have nothing against it if
you
chose to remove the pure Sage code. It's up to you.
- Backticks are missing around `Sp(x,y)` and others.
- We have `SimplecticGraph` and `SimplecticDualPolarGraph` -- should we
uniformize the `Polar` somehow?
- singilar
- Can you please remove/change all tests that take more than 2 seconds?
Don't
build instances larger than is necessary to *test* your code. With your
branch:
{{{
sage -t --long families.py
[280 tests, 44.02 s]
}}}
With the latest beta
{{{
sage -t --long families.py
[250 tests, 19.95 s]
}}}
- Some graphs are not defined on a html page, and for those you link
toward
"Distance-regular graphs". As this is much harder to find than a web
page,
could you provide some quick definition of the class, just to give the
user
"an idea"?
- You may want (it's up to you) to add "SEEALSO" blocks between your
methods.
- As we now have many of these polar graphs, you may want (it's up to you)
to
split them from the "Graph families" block of the index
(http://doc.sagemath.org/html/en/reference/graphs/sage/graphs/graph_generators.html)
and give them a block of their own.
Thank you *very* much for this code.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18997#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
