#18997: Unitary and symplectic (dual) polar graphs
-------------------------+-------------------------------------------------
Reporter: | Owner:
dimpase | Status: needs_work
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Nathann Cohen
theory | Work issues:
Keywords: | Commit:
Authors: Dima | acc985a045f02a1c796accd9a029ae809a0a92fd
Pasechnik | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dimpase/unitary |
Dependencies: |
#18972 |
-------------------------+-------------------------------------------------
Comment (by dimpase):
Replying to [comment:24 ncohen]:
> Helloooooooo Dima,
>
> - About the methods with a "algorithm" keyword: some of them do not have
an
> `INPUT` block where the parameter is described. Also, it would be
better if
> instead of checking `!= 'gap'` you tested `algorithm =='Gap'` then
`algorithm
> is None` and finally raised an exception if the argument does not
beelong to
> the allowed list. This being said, I would have nothing against it if
you
> chose to remove the pure Sage code. It's up to you.
it's always better to have 2 implementations... I'll rearrange as you ask.
>
> - Backticks are missing around `Sp(x,y)` and others.
>
> - We have `SimplecticGraph` and `SimplecticDualPolarGraph` -- should we
> uniformize the `Polar` somehow?
yep, how about renaming `SimplecticGraph` to `SimplecticPolarGraph` and
make `SimplecticGraph` a deprecated alias to `SimplecticPolarGraph`?
> - Can you please remove/change all tests that take more than 2 seconds?
How about I'll move them into examples and mark them # not tested (long
time)?
They test "generic" situations, whereas all the small examples there are
kinds of corner cases.
> - Some graphs are not defined on a html page, and for those you link
toward
> "Distance-regular graphs". As this is much harder to find than a web
page,
> could you provide some quick definition of the class, just to give the
user
> "an idea"?
all these `SymplecticPolar`, `OrthogonalPolar`, etc are very similar, as
well as all `SymplecticDualPolar` etc.
There is a freely available preprint that describes them in detail:
https://repository.cwi.nl/noauth/search/fullrecord.php?publnr=6775
I'd rather include this as a reference.
Perhaps it's more meaningful to create a separate module, say
polar_families.py,
where we move all them, as well as `AffinePolar` guys. Then a doc can be
written
in the top of this new module.
We could also extend the wikipedia page https://en.wikipedia.org/wiki
/Distance-regular_graph and have docs there...
>
> - You may want (it's up to you) to add "SEEALSO" blocks between your
methods.
>
> - As we now have many of these polar graphs, you may want (it's up to
you) to
> split them from the "Graph families" block of the index
>
(http://doc.sagemath.org/html/en/reference/graphs/sage/graphs/graph_generators.html)
> and give them a block of their own.
this would be even more meaningful with a new module.
--
Ticket URL: <http://trac.sagemath.org/ticket/18997#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
