#18941: Poset documentation polishing: chains and antichains
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  documentation      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:  Kevin Dilks
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/poset_polishing_chains|  ecb16e648cdff2cb22bc88c7fd01f114af8006a5
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 > I added some tests. As Macaulay2 has function `dilworthNumber`, I added
 the synonym to docstring of `widht`; this is non-relating change.

 Okay.

 - You must add a 'the' before 'given' in the description of
 'is_chain_of_poset', in the index.

 - This should work, and it does not:
 {{{
 sage: posets.DiamondPoset(4).is_chain_of_poset(iter([3]),ordered=True)
 ...
 TypeError: ordered=True not compatible with type <type 'listiterator'> for
 elms
 }}}

 You cannot rely on things like the existence of `__getitem__` to deduce
 something unrelated, like whether the ordering "matters" or not. You can
 rely on existing standards, but defining one in a patch won't make it
 true. In particular:

 {{{
 sage: Set([1,2,3])[0]
 1
 }}}

 Say that it only take a list as input or do nothing. TIf the user provides
 a set and says that the order matters, well, I say that (s)he should be
 bitten as a result.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/18941#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to