#18937: Upgrade patchbot again
-------------------------------------+-------------------------------------
       Reporter:  chapoton           |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.9
      Component:  packages:          |   Resolution:
  optional                           |    Merged in:
       Keywords:  patchbot           |    Reviewers:  Jeroen Demeyer,
        Authors:  Frédéric Chapoton  |  Nathann Cohen, Vincent Delecroix
Report Upstream:  N/A                |  Work issues:
         Branch:  u/chapoton/18937   |       Commit:
   Dependencies:                     |  5f5706434f184eafc41ed4c0dad9b76abe1293b7
                                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Replying to [comment:96 chapoton]:
 > I find it very annoying that some tests do not pass if the doc is not
 build.

 We will not change that in this ticket.

 > In the current state, the plugin "plugins.docbuild" is indeed
 mandatory, otherwise the doc is not build and therefore the tests do not
 pass.
 >
 > Some time ago, the doc was build once with a "make" and then again in
 the optional "docbuild" plugin. Now it is only build once in the plugin.
 >
 > I can enforce in the code that the plugin "docbuild" is always
 activated.
 >
 > OR I can step back and build the doc during the initial "make" call. But
 then doc failure will be again reported as Build failure, and the
 "docbuild" plugin will again become useless.

 IMO, it is better to report properly docbuild errors and hence to separate
 the "make doc" from the "make build". That being said, I have no opinion
 whether or not the "make doc" process should stay a module. And I have
 nothing against mandatory modules.

--
Ticket URL: <http://trac.sagemath.org/ticket/18937#comment:97>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to