#19141: Poset documentation polishing: Boolean-valued properties
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-6.10
Component: combinatorics | Resolution:
Keywords: poset | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/poset_documentation_polishing__boolean_valued_properties|
39d1e185906821d6fcece65560e1081eb11e1493
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by kdilks):
* status: needs_review => positive_review
Comment:
My main point is that I really think {{{is_chain()}}} should be the method
that checks if a given set is a chain of the poset. Maybe we could rename
the other method {{{is_chain_poset()}}} ? But maybe that can be a separate
ticket, I'll set positive review for the changes made here.
I think it's fine the way that it is. For {{{is_rank_symmetric()}}}, we
have a separate category of ranked posets for it to be a method on, and
the question doesn't really make sense for a non-ranked poset. With
{{{is_slender()}}}, I don't think we have a category framework for
graded/bounded posets. Also, the question of whether a poset has an
interval of rank 2 with more than 4 elements may be of interest
independent of the assumption that it's graded/bounded, and it's easy
enough to add your own checks with {{{is_bounded()}}} and
{{{is_graded()}}} if you really want to make it necessary. Maybe the right
compromise would be to add optional parameters {{{bounded}}} and
{{{graded}}} that can be set depending on whether you feel like imposing
those conditions or not.
--
Ticket URL: <http://trac.sagemath.org/ticket/19141#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
