#6102: cohomology ring of simplicial complexes
-------------------------------------+-------------------------------------
       Reporter:  bantieau           |        Owner:  bantieau
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  algebraic          |   Resolution:
  topology                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  John Palmieri      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/jhpalmieri/AT-   |  0d2ea83c0d4a66ff254e9382376b04f90d921964
  model                              |     Stopgaps:
   Dependencies:  #19179             |
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * milestone:  sage-6.4 => sage-6.10


Comment:

 Those are some very good improvements.

 I really don't like this:
 {{{#!python
 # diff is sparse and low density. Dense matrices are faster
 # over finite fields, but for low density matrices, sparse
 # matrices are faster over the rationals.
 if base_ring != QQ:
     diff = diff.dense_matrix()
 }}}
 It's not a blocker for this to get a positive review, but it bugs me. Plus
 the extra time to convert it to a dense matrix...

 I did some quick digging and there is apparently a slew of tickets on
 improving sparse or modn vectors/matrices: #19076 (and therein), #18231,
 #15104, #10312, #18312, #2705.

 Was there anything in your timings to suggest a good place to go look for
 just using sparse matrices? Did you also test with my fixes for #19377 and
 #19378 (and forcing sparse matrices, or are they even necessary)?

 Is there anything else you'd like to do to this before I set it to
 positive review?

--
Ticket URL: <http://trac.sagemath.org/ticket/6102#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to