#19459: Fix containment
-------------------------------------+-------------------------------------
Reporter: switzel | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.10
Component: coercion | Resolution:
Keywords: | Merged in:
Authors: Stefan Witzel | Reviewers: Peter Bruin
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/switzel/fix_containment | 4943cda8c49a4336284861b9beb92bf731954d7e
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by pbruin):
* status: needs_review => needs_work
Comment:
Replying to [comment:13 switzel]:
> Well, seems like what happened is precisely what you said you would be
surprised if it happened: the example wants `LaurentSeries.power_series()`
to raise an `ArithmeticError` rather than a `TypeError`.
I meant that I didn't expect code (either Sage code or external programs)
to specifically depend on an `ArithmeticError`, For a doctest that just
exists to show that an error is raised for invalid input, it is certainly
no surprise that it has to be adapted when the specific error changes...
One more thing: could you please add a reference to this Trac ticket in
the doctest (using the syntax {{{:trac:`19459`}}})? See the item
"Bugfixes" on
http://doc.sagemath.org/html/en/developer/reviewer_checklist.html
(admittedly this is the reviewer's checklist, but it is useful as an
author's checklist as well...)
--
Ticket URL: <http://trac.sagemath.org/ticket/19459#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
