#19152: {Real,Complex}Ball: Miscellaneous fixes and improvements
-------------------------------------+-------------------------------------
       Reporter:  mmezzarobba        |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.10
      Component:  numerical          |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Marc Mezzarobba    |    Reviewers:  Clemens Heuberger
Report Upstream:  N/A                |  Work issues:
         Branch:  public/19152-arb-  |       Commit:
  misc                               |  c8873f0d1fac0deb01a75d2203907b5a77fecf0e
   Dependencies:  #19063             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by mmezzarobba):

 Replying to [comment:49 cheuberg]:
 > It makes reviewing harder as I do not really want to interfere with the
 polynomials guys ...

 Ok, sorry, I'll try to avoid doing that in tickets you are likely to
 review.

 > I'd like to know what `ampl` shall be (any rational number? ball?) and
 that I'd prefer to state that
 > OUTPUT:
 >
 > A complex ball.
 >
 > (the description seems to be worded as an inline operation, but it
 actually returns a new ball).

 Done.

 > I'd prefer something which separates the two messages of the one
 sentence, e.g. "Use `__nonzero__()` to check that a ball is not exactly
 the zero ball (for instance, to determine the “degree” of a polynomial
 with ball coefficients). In fact, `__nonzero__()` is the negation of
 `is_zero()`, whereas `is_nonzero()` only returns `True` if `0` is known
 not to be in the ball."

 Done.

 > Further remark:
 >
 > 19. The AUTHORS section at the beginning of the files is not accurate: I
 started those files, but most of their contents has been written by you.
 So please either add your name or remove mine.

 I'll be consistent with what I said on sage-devel a few weeks ago and
 simply remove the AUTHORS block :-). But of course please feel free to add
 us both back if you prefer.

 Replying to [comment:50 cheuberg]:
 > I would not mind having RBF, CBF, RealBallField and ComplexBallField in
 the global name space; this is how most of sage seems to work. But this
 could also happen in another ticket ...

 Done — I still don't like that very much, but since everyone seems to
 agree...
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=f51cd86059537aa22166801019a2fbd05a00a1b0
 f51cd86]||{{{{Real,Complex}Ball: better document add_error()}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=49a2e9bececd02d2d60037230aead8a7ffa1127a
 49a2e9b]||{{{{Real,Complex}Ball: improve doc of is_nonzero()}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=154b65d522d8248944d4cf23dbe902313cb21eb3
 154b65d]||{{{{real,complex}_arb: rm AUTHORS blocks}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=e22f4074539b1833befb7f24bd700a7fe11589a9
 e22f407]||{{{add RealBallField & friends to the global namespace}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c8873f0d1fac0deb01a75d2203907b5a77fecf0e
 c8873f0]||{{{real_ball: one more instance of [non]zero -> True/False}}}||
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=f51cd86059537aa22166801019a2fbd05a00a1b0
 f51cd86]||{{{{Real,Complex}Ball: better document add_error()}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=49a2e9bececd02d2d60037230aead8a7ffa1127a
 49a2e9b]||{{{{Real,Complex}Ball: improve doc of is_nonzero()}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=154b65d522d8248944d4cf23dbe902313cb21eb3
 154b65d]||{{{{real,complex}_arb: rm AUTHORS blocks}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=e22f4074539b1833befb7f24bd700a7fe11589a9
 e22f407]||{{{add RealBallField & friends to the global namespace}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c8873f0d1fac0deb01a75d2203907b5a77fecf0e
 c8873f0]||{{{real_ball: one more instance of [non]zero -> True/False}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19152#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to