#19585: Improve efficiency of calling GAP functions
-------------------------------------+-------------------------------------
       Reporter:  jaanos             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  interfaces         |   Resolution:
       Keywords:  GAP functions      |    Merged in:
  interface                          |    Reviewers:
        Authors:  Janoš Vidali       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  46f1391fd13052e8c684ed3e96434143a58860dc
  u/jaanos/improve_calling_gap_function-19585|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by jaanos):

 * commit:  48409b03cc37684677c441eddc6ae54584cdd13c =>
     46f1391fd13052e8c684ed3e96434143a58860dc


Comment:

 I have removed the check for empty output. Since most functions we call
 will return a value and not print anything, there is actually one check
 less in these cases.

 As far as `IsIdenticalObj` is concerned, it surprises me too that it
 should not be cheap. I don't suppose that `=` is actually cheaper?

 Actually, what we could do is cut the number of times `eval` is called, by
 simply running the three GAP commands in one `eval`. I'll try that, and if
 there is any speedup from doing that, I'll push the change to this ticket.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=46f1391fd13052e8c684ed3e96434143a58860dc
 46f1391]||{{{Call IsIdenticalObj even when there is some output, to
 prevent ignoring the returned value when there is printed output}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19585#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to