#19585: Improve efficiency of calling GAP functions
-------------------------------------+-------------------------------------
Reporter: jaanos | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: interfaces | Resolution:
Keywords: GAP functions | Merged in:
interface | Reviewers: Travis Scrimshaw
Authors: Janoš Vidali | Work issues:
Report Upstream: N/A | Commit:
Branch: | f59926575333e34976901f92c1f070e0c168a0b9
u/tscrim/improve_calling_gap_function-19585| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* commit: 46f1391fd13052e8c684ed3e96434143a58860dc =>
f59926575333e34976901f92c1f070e0c168a0b9
* branch: u/jaanos/improve_calling_gap_function-19585 =>
u/tscrim/improve_calling_gap_function-19585
* reviewer: => Travis Scrimshaw
Comment:
By combining the two commands, I get a net speedup:
{{{
sage: P = groups.permutation.Symmetric(7)
sage: %timeit P.conjugacy_classes_subgroups()
1 loops, best of 3: 390 ms per loop
sage: P = groups.permutation.Symmetric(2)
sage: %timeit P.conjugacy_classes_subgroups()
100 loops, best of 3: 7.87 ms per loop
}}}
vs current `develop`:
{{{
sage: P = groups.permutation.Symmetric(7)
sage: %timeit P.conjugacy_classes_subgroups()
1 loops, best of 3: 403 ms per loop
sage: P = groups.permutation.Symmetric(2)
sage: %timeit P.conjugacy_classes_subgroups()
100 loops, best of 3: 8.08 ms per loop
}}}
I think we need to mitigate then number of `eval` calls that get made more
so than doing the check in Sage. So if you're happy with my last change,
then I'm okay with setting this to positive review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=f59926575333e34976901f92c1f070e0c168a0b9
f599265]||{{{Combining the two commands for more speed.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19585#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
