#19610: Fix dependencies on PARI
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  cython             |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/fix_dependencies_on_pari|  5d0e4d30588ab0f13bfc0770d2b4b407d7580035
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by leif):

 Replying to [comment:24 jdemeyer]:
 > If you want to discuss more general linking issues, open a thread on
 `sage-devel`.

 Well, ''you'' asked general questions.

 > Anyway, can we please go back to the review of this ticket?

 `interrupt.so` still does not need GMP, but with your current patch, GMP
 gets linked to it.  (Worse, not even the Cython code, `interrupt.*`, where
 `paridecl` gets imported, uses any PARI stuff.)  I agree that copy-pasting
 parts of PARI headers (although it's just a single line) is not nice, but
 that's more a problem of the PARI headers and I was simply getting bored
 of trying which to include and which not.  (Probably the top-level one is
 ok as well, but seems overkill to me.)

 I still don't like the IMHO redundant `libraries = pari gmp` (in
 `paridecl.pxd`), but it's not a major issue either (until we or some
 people switch to PARI with a different kernel at least).

 Perhaps cc some more reviewers, e.g. François.

--
Ticket URL: <http://trac.sagemath.org/ticket/19610#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to