#19552: images and preimages for projective subscheme
-------------------------------------+-------------------------------------
Reporter: bhutz | Owner: bhutz
Type: enhancement | Status: needs_info
Priority: minor | Milestone: sage-6.10
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: subscheme | Reviewers: Vincent Delecroix
iteration | Work issues:
Authors: Ben Hutz | Commit:
Report Upstream: N/A | 5635becc9dd31f1e81c10f5422b37607e3ecdaa3
Branch: | Stopgaps:
u/bhutz/ticket/19552 |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_info
* reviewer: => Vincent Delecroix
Comment:
Hello,
1. Could you split the documentation strings into a '''one line'''
description followed by a paragraph.
2. For the input, I would prefer to follow the Python conventions
- `x.orbit(f, 3)` -> `[x, f(x), f^2(x)]`
- `x.orbit(f, 2, 5)` -> `[f^2(x), f^3(x), f^4(x)]`
In other words having a `def orbit(self, f, n, m=None)`.
3. Is there really a need for that many functions:
- `orbit` (this is achieved by a simple loop)
- `nth_iterate` (this is more or less equivalent to `.orbit(f, (n,n+1))`).
- `forward_image` (this is more or less equivalent to `.orbit(f,
(0,1))`)... and why not using `f(self)` here? If this is needed by call,
then it could be a private method `_forward_image`.
- `preimage` (this should be equivalent to `.orbit(f, (-1,0))`)
- `__call__`
--
Ticket URL: <http://trac.sagemath.org/ticket/19552#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
