#19801: LatticePosets: Add pseudocomplements
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.0
Component: combinatorics | Resolution:
Keywords: lattice | Merged in:
Authors: Jori Mäntysalo | Reviewers: Daniel Krenn
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/pseudocomplement | a9c00e2d691282e6d77a63827b2ada33ceaaeb6d
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by dkrenn):
Some more comments (sorry I've missed some things last time):
7. lattices.py, L261: ident to after "(" of line above and PEP8-ify.
8. INPUT-blocks in hasse_diagram.py and lattices.py: According to
developer guide put a `--` instead of the `-` after the parameter name.
9. I see the INPUT/OUTPUT-blocks more as a technical description, so
instead of
{{{
``element`` - an element of the lattice whose pseudocomplement is
returned.
}}}
I would write simply
{{{
``element`` - an element of the lattice
}}}
Similarly in the OUTPUT-block I would rewrite
{{{
The pseudocomplement of an ``element``, if it exists. Otherwise ``None``.
}}}
to
{{{
An element of the lattice or ``None`` if the pseudocomplement does not
exist.
}}}
(maybe rewrite the second part...)
Now you get the additional information that the element returned is from
the lattice (instead of the already known fact that I get the
pseudocomplement).
10. hasse_diagram.py
{{{
[...] It may not exist, and then the function returns ``None``.
}}}
This paragraph contains the actual defintion of the pseudocomplement.
May the return value should be mentioned in the OUTPUT block (add an
OUTPUT block to this function). INPUT/OUTPUT-block here could say that
``element`` and the returned value are integers.
I hope you don't find this too picky... (on the other hand, you wanted me
to review it ;) )
Test pass, doc builds and looks okay.
--
Ticket URL: <http://trac.sagemath.org/ticket/19801#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
