#19801: LatticePosets: Add pseudocomplements
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.0
Component: combinatorics | Resolution:
Keywords: lattice | Merged in:
Authors: Jori Mäntysalo | Reviewers: Daniel Krenn
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/pseudocomplement | 84c8010dbfbd19718b593f3be134bd89b4c92bf8
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jmantysalo):
Replying to [comment:7 dkrenn]:
> I hope you don't find this too picky... (on the other hand, you wanted
me to review it ;) )
Better to do this correctly in first time. And both picky and non-picky
reviewer are better than no reviewer at all.
> 8. INPUT-blocks in hasse_diagram.py and lattices.py: According to
developer guide put a `--` instead of the `-` after the parameter name.
Yes, clearly.
> 7. lattices.py, L261: ident to after "(" of line above and PEP8-ify.
I corrected this, and also same for `is_pseudocomplemented()`. Actually I
don't know what would be best way to make an example. They should be small
but not trivial. Also 80 character limit is maybe too restrictive for
examples? A picture?
> 9. I see the INPUT/OUTPUT-blocks more as a technical description, so
instead of
> {{{
> ``element`` - an element of the lattice whose pseudocomplement is
returned.
> }}}
> I would write simply
> {{{
> ``element`` - an element of the lattice
OK. There is a point in this (and on comment 10 which is similar).
--
Ticket URL: <http://trac.sagemath.org/ticket/19801#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
