#19540: AsymptoticExpansion.factorial
-------------------------------------+-------------------------------------
       Reporter:  dkrenn             |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-7.1
      Component:  asymptotic         |   Resolution:
  expansions                         |    Merged in:
       Keywords:                     |    Reviewers:  Clemens Heuberger
        Authors:  Daniel Krenn       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  23948e43b8038cfe7948fab2f5058cab8f734dbd
  u/dkrenn/asy/factorial             |     Stopgaps:
   Dependencies:  #19306, #19521,    |
  #19528, #19944                     |
-------------------------------------+-------------------------------------
Changes (by cheuberg):

 * status:  needs_review => needs_info


Comment:

 1. The growth elements call `self.parent()._var_.variable_names()`. I am
 wondering why they do not simply call `self.parent().variable_names()`.
 2. Why can't a generic growth element decide on its own? It could simply
 call
 {{{
 if self.is_one():
    return tuple()
 else:
    return self.parent()._var_.variable_names()
 }}}
    which would probably end in a desaster if called on a generic growth
 element, but we are not supposed to instantiate generic growth elements
 anyway ...

 The rest is fine for me.

--
Ticket URL: <http://trac.sagemath.org/ticket/19540#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to