#19540: AsymptoticExpansion.factorial
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-7.1
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: | Reviewers: Clemens Heuberger
Authors: Daniel Krenn | Work issues:
Report Upstream: N/A | Commit:
Branch: | 0e6a0c554fbff9ba6fd36f5309e9ec6e7a8eb7f3
u/cheuberg/asy/factorial | Stopgaps:
Dependencies: #19306, #19521, |
#19528, #19944 |
-------------------------------------+-------------------------------------
Changes (by dkrenn):
* status: needs_review => positive_review
Comment:
Replying to [comment:15 cheuberg]:
> I added a doctest because I wanted to know what happens for a generic
growth group. At first glance, it was surprising that I do get an
`AttributeError` instead of a `NotImplementedError`. The method `is_one`
seems to be contributed by the category.
>
> I noticed that the docstring of `GenericGrowthGroup` (and the other
growth groups) says "It has to be a subcategory of Join of Category of
groups and Category of posets. This is also the default category if None
is specified." which is a relict from the past.
>
> Furthermore, we have
> {{{
> # set everything up to determine category
> from sage.categories.sets_cat import Sets
> from sage.categories.posets import Posets
> from sage.categories.magmas import Magmas
> from sage.categories.additive_magmas import AdditiveMagmas
> }}}
> in the class `GenericGrowthGroup` which shows all these Categories in
the documentation, similar as #20045.
>
> Shall we fix those in a separate ticket or right here?
This is now #20077.
> Please cross-review my commit and set to positive_review if you are
satisfied.
Done.
--
Ticket URL: <http://trac.sagemath.org/ticket/19540#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
