#19884: LatticePosets: Add is_relatively_complemented()
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-7.2
      Component:  combinatorics      |   Resolution:
       Keywords:  latticeposet       |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:  Travis Scrimshaw
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/posets/add_is_relatively_complemented-19884|  
3170b43a8966c7cb8be789cc52465dab375d71df
   Dependencies:  #19878             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * status:  needs_work => positive_review
 * commit:  a08fac06be39a07de8f1c82ba0d0f2a3733579be =>
     3170b43a8966c7cb8be789cc52465dab375d71df
 * dependencies:   => #19878
 * branch:  u/jmantysalo/relatively_complemented =>
     public/posets/add_is_relatively_complemented-19884


Comment:

 Chances are that it this will get merged, along with #19878, in beta1. So
 I have merged in #19878 because that is 0 additional work in reviewing. I
 did not get any docbuilding, no doctesting errors with #19878, and your
 changes look good. So I'm setting a positive review.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=e2e53d30c98f92d91b99506b70ab8e7e6f5397b0
 e2e53d3]||{{{Merge branch 'u/jmantysalo/relatively_complemented' of
 trac.sagemath.org:sage into
 public/posets/add_is_relatively_complemented-19884}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=9b0b30bde968f4f0c697e81e2503e562b3ff31ea
 9b0b30b]||{{{Add coatomic, simpler code.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=533d660eaf56a4a19116e28759c5d408c860999b
 533d660]||{{{Spaces removed.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=3170b43a8966c7cb8be789cc52465dab375d71df
 3170b43]||{{{Merge branch 'u/jmantysalo/simpler_atomic' of
 trac.sagemath.org:sage into
 public/posets/add_is_relatively_complemented-19884}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19884#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to