#20256: Implement conversion Infinity <-> PARI
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-7.2
      Component:  interfaces         |   Resolution:
       Keywords:  pari, infinity,    |    Merged in:
  days71                             |    Reviewers:  Jeroen Demeyer
        Authors:  Kiran Kedlaya      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  27357f9c728618232f21ccc48807513319d8461b
  u/kedlaya/implement_conversion_infinity_____pari|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by jdemeyer):

 * status:  needs_review => needs_work
 * reviewer:   => Jeroen Demeyer


Comment:

 A few details:

 In `infinity.py`:

 1. Remove the commented-out line `#from sage.libs.all import pari,
 pari_gen` (I don't know why the import does not work, but that's not so
 important)

 2. Is there a possibility that `self._sign` is not 1 or -1? It might be
 safer to use `if self._sign >= 0: .... else: .....` and remove the `raise
 TypeError`.

 3. Replace `TESTS::` by `EXAMPLES::` in the `_pari_()` documentation.

 In `gen.pyx`:

 4. Add doctests for both pieces of added code.

--
Ticket URL: <http://trac.sagemath.org/ticket/20256#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to