#20256: Implement conversion Infinity <-> PARI
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.2
Component: interfaces | Resolution:
Keywords: pari, infinity, | Merged in:
days71 | Reviewers: Jeroen Demeyer
Authors: Kiran Kedlaya | Work issues:
Report Upstream: N/A | Commit:
Branch: | 3832116557c63a1495e395d5eb3c9036ba701c1e
u/kedlaya/implement_conversion_infinity_____pari| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by kedlaya):
* status: needs_work => needs_review
Comment:
Replying to [comment:5 jdemeyer]:
> A few details:
>
> In `infinity.py`:
>
> 1. Remove the commented-out line `#from sage.libs.all import pari,
pari_gen` (I don't know why the import does not work, but that's not so
important)
>
> 2. Is there a possibility that `self._sign` is not 1 or -1? It might be
safer to use `if self._sign >= 0: .... else: .....` and remove the `raise
TypeError`.
>
> 3. Replace `TESTS::` by `EXAMPLES::` in the `_pari_()` documentation.
>
> In `gen.pyx`:
>
> 4. Add doctests for both pieces of added code.
All changes made. In gen.pyx, the comments indicate that the doctests for
gentoobj go in gen.python(), so that's where I added them.
--
Ticket URL: <http://trac.sagemath.org/ticket/20256#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
