#20198: `LinearCode(C)` for some code `C` should construct a code
-------------------------------------+-------------------------------------
Reporter: jsrn | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.1
Component: coding theory | Resolution:
Keywords: linear code, | Merged in:
beginner | Reviewers:
Authors: Charles Prior | Work issues:
Report Upstream: N/A | Commit:
Branch: | b1e49eacc83ca0ac69d042460ee6b65a028dd240
u/cprior/_linearcode_c___for_some_code__c__should_construct_a_code|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by cprior):
Replying to [comment:6 jsrn]:
> I think your logic can be simplified somewhat: In the code case, you
should use something like `generator = generator.generator_matrix()`
instead. You are promised that this is a full rank matrix (that's part of
the contract of that method). So the check that `basis` is as long as the
rank of `generator` is not necessary here and can be moved into the `try`
block for the generator matrix case. And now the computation of `basis`
does not have to be done twice.
>
> Best,
> Johan
I implemented your suggestions, let me know what you think.
Replying to [comment:5 jsrn]:
> Awesome, thanks for the patch! I'll look at it momentarily.
>
> You're right about my typo: it should have been `^23` and not `^7`. What
do you mean "superseding `decode_to_code`" -- that method is not
superseded (contrarily, that and `decode_to_message` both supersede
`decode`).
>
> Best,
> Johan
Sorry I was unclear. I meant that ``decode_to_code`` supersedes
``decode``.
--
Ticket URL: <http://trac.sagemath.org/ticket/20198#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
