#20198: `LinearCode(C)` for some code `C` should construct a code
-------------------------------------+-------------------------------------
Reporter: jsrn | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: coding theory | Resolution:
Keywords: linear code, | Merged in:
beginner | Reviewers: Johan Sebastian
Authors: Charles Prior | Rosenkilde Nielsen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jsrn/_linearcode_c___for_some_code__c__should_construct_a_code|
6162d956dff16a29fa9a57fe28329473a8e1c706
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jsrn):
* reviewer: => Johan Sebastian Rosenkilde Nielsen
* commit: b1e49eacc83ca0ac69d042460ee6b65a028dd240 =>
6162d956dff16a29fa9a57fe28329473a8e1c706
Comment:
>
> I implemented your suggestions, let me know what you think.
You still needlessly recomputed `basis` so I removed that, and also
removed some other minor recomputations (which are probably cached anyway,
but still). Other than that your code looks good and I accept it. I've run
tests on `src/sage/coding` and it's currently testing the rest of the Sage
lib, but I'm not expecting any problems. If you can accept my changes,
just set to positive_review :-)
Best,
Johan
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=140a743cdd9baaf9401534be8a2a5388ea11f518
140a743]||{{{minor doc improvements}}}||
||[http://git.sagemath.org/sage.git/commit/?id=48ea66f7cf66203b8b895916b624e9e1ba918e14
48ea66f]||{{{Merge branch
'u/cprior/_linearcode_c___for_some_code__c__should_construct_a_code' of
git://trac.sagemath.org/sage into 20198_linear_code_from_code}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6162d956dff16a29fa9a57fe28329473a8e1c706
6162d95]||{{{Avoid some recomputations. Clarify a comment}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/20198#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
