#20274: LatticePoset: trivial additions
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-7.2
Component: combinatorics | Resolution:
Keywords: latticeposet | Merged in:
Authors: Jori Mäntysalo | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__trivial_additions|
7bc6924734e34c189132648e918ba4865c821ea6
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
Replying to [comment:7 jmantysalo]:
> Replying to [comment:5 tscrim]:
> > - I (still) disagree with this type of change:
> > {{{#!diff
> > - Return ``True`` if ``self`` is a supersolvable lattice and
> > + Return ``True`` if the lattice is supersolvable and
> > }}}
>
> Duh. Done that. Now it is inconsistent with other functions in the file.
We should have a style guide for this kind of things.
There is an on-going debate about whether to refer to {{{``self``}}} in
any docstring (guess what side I am on :P). However you should remove the
comma `,` before the `and` to be (English) grammatically correct (as
{{{otherwise ``False``}}} is not a complete sentence).
--
Ticket URL: <http://trac.sagemath.org/ticket/20274#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
