#20274: LatticePoset: trivial additions
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-7.2
Component: combinatorics | Resolution:
Keywords: latticeposet | Merged in:
Authors: Jori Mäntysalo | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__trivial_additions|
7384ce3a2a306c5e6511c8915ce20b8c9469c2df
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jmantysalo):
Replying to [comment:8 tscrim]:
>> Duh. Done that. Now it is inconsistent with other functions in the
file. We should have a style guide for this kind of things.
> There is an on-going debate about whether to refer to {{{``self``}}} in
any docstring (guess what side I am on :P).
OK. I don't have strong opinion, but if I must choose, then no `self`s in
docstring. Most important is to make a choose and stick on it.
> However you should remove the comma `,` before the `and` to be (English)
grammatically correct (as {{{otherwise ``False``}}} is not a complete
sentence).
Done that. However, almost every docstring has the same problem. I didn't
touch them now.
--
Ticket URL: <http://trac.sagemath.org/ticket/20274#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
