#19422: A new structure for Punctured Codes
-------------------------------------+-------------------------------------
       Reporter:  dlucas             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.2
      Component:  coding theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Lucas        |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dlucas/punctured_codes           |  659105c517f3e6115e70a9f502f3681ca9075086
   Dependencies:  #19653             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by dlucas):

 * status:  needs_work => needs_review


Comment:

 Hello Julien,

 Thanks for your thorough review!

 I followed all your suggestions (good idea to change the set of points to
 a list!).
 Some remarks/answers follow:

 - As `positions` is now a set, the test of duplicate positions in the
 constructor is no longer needed.
 - Open question: now that I changed `positions` to a set, the `str`
 methods return the ugly str format of a set: `set([3,4])` for `{3, 4}`.
 Which means the string representation of a punctured code now states
 `PuncturedCode coming from ... punctured in position(s) set([pos])` which
 is quite ugly... So, do you think I should keep that, or, only for these
 `str` methods return a list while it might be a bit confusing for the user
 because he/she entered a set a got a list?

 > sage is stuck (infinite loop ?) when I run this:

 Oh, yes, it's not an infinite loop! It's because it builds the original
 decoder of your code, namely a `SyndromeDecoder` for a linear code over
 GF(7), length 11, dimension 5... Which takes a while because of the table
 of syndromes which is heavy to build.

 Best,

 David

--
Ticket URL: <http://trac.sagemath.org/ticket/19422#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to