#7109: [with patch, needs review] polyhedra bugs with linearities, rewrite
proposal
---------------------------+------------------------------------------------
Reporter: vbraun | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-feature
Component: geometry | Keywords: polyhedra
Work_issues: | Author:
Reviewer: | Merged:
---------------------------+------------------------------------------------
Comment(by mhampton):
OK, I am beginning to add doctests to everything that needs them.
One thing I don't like so far is you preserved a lot of function names,
but they return totally different things than they used to. This breaks
basically all of my existing use of the code, and presumably other
people's as well. For example, the vertices() function doesn't return a
list of lists of numbers, but instead a generator, and the generator
returns some higher-level object instead of a list.
I think some break in back-compatability is definitely worth it, since I
think your design is a lot cleaner and better, but it should be minimized.
A compromise would be if I modified some of those functions to behave as
before, and we created some new functions that behave as yours do. So for
example, vertices() would return a list of lists as before (or perhaps a
list of vectors, that would be different but wouldn't break everything),
and there would be another function that returned the generator. I don't
know what a good name would be, perhaps something like vertex_generator().
-Marshall
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7109#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
