#20660: Add Certificate to is_isomorphic() in the matroids package
-------------------------------------+-------------------------------------
       Reporter:  tara               |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-7.3
      Component:  matroid theory     |   Resolution:
       Keywords:  matroid,           |    Merged in:
  isomorphism                        |    Reviewers:
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  4ee8641a27d6ac2492f0233c057754af7acfc99f
  public/ticket/20660                |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by tara):

 Replying to [comment:5 Stefan]:
 > If you're calling another instance of the is_isomorphic method, you
 should pass through all parameters. So the line you quote needs to be
 changed to
 >
 > {{{
 > if not isinstance(other, BasisMatroid):
 >     return BasisExchangeMatroid._is_isomorphic(self, other, cert)
 > }}}

 My question was why we are calling `is_isomorphic` instead of
 `isomorphism`. For instance, the following comes from an unedited version
 of sage. But I would expect a dictionary instead of a boolean.
 {{{
 sage: from sage.matroids.advanced import *
 sage: M1 = BasisMatroid(matroids.Wheel(3))
 sage: M2 = matroids.CompleteGraphic(4)
 sage: M1.isomorphism(M2)
 True
 }}}

 So I think that this is a bug in Sage.

--
Ticket URL: <http://trac.sagemath.org/ticket/20660#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to