#20660: Add Certificate to is_isomorphic() in the matroids package
-------------------------------------+-------------------------------------
Reporter: tara | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.3
Component: matroid theory | Resolution:
Keywords: matroid, | Merged in:
isomorphism | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 12a4b3d50d34912f44c6f700b95fdc7360612162
public/ticket/20660 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by yomcat):
* status: needs_review => needs_work
Comment:
A few minor things:
* There's some extraneous whitespace after your commas -- use `git trac
review` to see it easily.
* You haven't fully made the `cert` to `certificate` change. The pxd files
are causing errors upon compilation because of it.
* In the doctests, you should specify the option, ie: `M.is_isomorphic(N,
certificate=True)`
* In the output part of the docstring, you should say what that the
dictionary shows the isomorphism, and None is output when the matroids
aren't isomorphic.
--
Ticket URL: <http://trac.sagemath.org/ticket/20660#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
