#20660: Add Certificate to is_isomorphic() in the matroids package
-------------------------------------+-------------------------------------
Reporter: tara | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.3
Component: matroid theory | Resolution:
Keywords: matroid, | Merged in:
isomorphism | Reviewers: Michael Welsh
Authors: Tara Fife | Work issues:
Report Upstream: N/A | Commit:
Branch: | 18db65aea44f52153f355a3ebada1a8a421e5876
public/ticket/20660 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Tara Fife', 'oldvalue': ''}):
* reviewer: => Michael Welsh
* author: => Tara Fife
Comment:
First, you have a bunch of doubled-up doctests (one with the explicit
option, one without).
This happens (it's due to a capital C):
{{{
sage -t --long --warn-long 69.0
src/sage/matroids/circuit_closures_matroid.pyx
**********************************************************************
File "src/sage/matroids/circuit_closures_matroid.pyx", line 393, in
sage.matroids.circuit_closures_matroid.CircuitClosuresMatroid._is_isomorphic
Failed example:
M1._is_isomorphic(M2, Certificate=True)
Exception raised:
Traceback (most recent call last):
File "/Applications/sage-devel/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 498, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Applications/sage-devel/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 861, in compile_and_execute
exec(compiled, globs)
File "<doctest
sage.matroids.circuit_closures_matroid.CircuitClosuresMatroid._is_isomorphic[9]>",
line 1, in <module>
M1._is_isomorphic(M2, Certificate=True)
File "sage/matroids/circuit_closures_matroid.pyx", line 358, in
sage.matroids.circuit_closures_matroid.CircuitClosuresMatroid._is_isomorphic
(/Applications/sage-
devel/src/build/cythonized/sage/matroids/circuit_closures_matroid.c:4575)
cpdef _is_isomorphic(self, other, certificate=False):
TypeError: _is_isomorphic() got an unexpected keyword argument
'Certificate'
**********************************************************************
1 item had failures:
1 of 12 in
sage.matroids.circuit_closures_matroid.CircuitClosuresMatroid._is_isomorphic
[81 tests, 1 failure, 0.30 s]
}}}
Last doctest in BasisExchangeMatroid is missing the explicit option.
Around line 2694 in `linear_matroid.pyx`, you've removed an extra space.
It should be `return True, None`.
You've dropped an I from INPUT around line 355 of
`circuit_closures_matroid.pyx`, and lines 3265, 4312, 5941 of
`linear_matroid.pyx`
--
Ticket URL: <http://trac.sagemath.org/ticket/20660#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
